Re: [PATCH v2 3/3] ASoC: tas6424: Allow disabling auto diagnostics for faster power-on

From: Mark Brown
Date: Fri Apr 27 2018 - 11:30:42 EST


On Fri, Apr 27, 2018 at 03:55:49PM +0200, Jean-Jacques Hiblot wrote:

> +static const char * const diags_enum_texts[] = {"OFF", "ON"};
> +static unsigned int diags_enum_values[] = {1, 0};
> +SOC_VALUE_ENUM_SINGLE_DECL(diags_enum, TAS6424_DC_DIAG_CTRL1,
> + TAS6424_LDGBYPASS_SHIFT, TAS6424_LDGBYPASS_MASK,
> + diags_enum_texts, diags_enum_values);
> +

This just just an on/off switch so it should be represented as a
standard _SINGLE() control with " Switch" at the end of the name so
userspace knows what to do with it.

Attachment: signature.asc
Description: PGP signature