Re: [PATCH] IB/nes: fix nes_netdev_start_xmit()'s return type
From: Doug Ledford
Date: Fri Apr 27 2018 - 14:08:20 EST
On Wed, 2018-04-25 at 18:35 +0300, Leon Romanovsky wrote:
> On Tue, Apr 24, 2018 at 08:36:12PM +0300, Leon Romanovsky wrote:
> > On Tue, Apr 24, 2018 at 03:15:45PM +0200, Luc Van Oostenryck wrote:
> > > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> > > which is a typedef for an enum type, but the implementation in this
> > > driver returns an 'int'.
> > >
> > > Fix this by returning 'netdev_tx_t' in this driver too.
> > >
> > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> > > ---
> > > drivers/infiniband/hw/nes/nes_nic.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ipoib_start_xmit() needs the same fix.
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Thanks, applied to for-rc.
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
Description: This is a digitally signed message part