Re: [PATCH] firmware: dmi: Add access to the SKU ID string

From: Simon Glass
Date: Fri Apr 27 2018 - 15:12:33 EST


Hi Jean,

On 27 April 2018 at 01:58, Jean Delvare <jdelvare@xxxxxxx> wrote:
> Hi Simon,
>
> On Tue, 24 Apr 2018 15:11:11 -0600, Simon Glass wrote:
>> This is used in some systems from user space for determining the identity
>> of the device.
>>
>> Expose this as a file so that that user-space tools don't need to read
>> from /sys/firmware/dmi/tables/DMI
>>
>> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
>> ---
>>
>> drivers/firmware/dmi-id.c | 2 ++
>> drivers/firmware/dmi_scan.c | 1 +
>> include/linux/mod_devicetable.h | 1 +
>> 3 files changed, 4 insertions(+)
>> (...)
>
> Looks good to me. Applied, thanks. For consistency I have moved product
> SKU before product family in all files, same order as in the DMI entry
> itself.

Sounds good, thanks.

- Simon