Re: [PATCH v6 04/24] ASoC: qdsp6: dt-bindings: Add q6afe dt bindings

From: Srinivas Kandagatla
Date: Fri Apr 27 2018 - 15:17:09 EST

On 27/04/18 19:32, Rob Herring wrote:
+= AFE DAIs (Digial Audio Interface)
+"dais" subnode of the AFE node represents dai specific configuration
+- #sound-dai-cells
+ Usage: required
+ Value type: <u32>
+ Definition: Must be 1
+- reg

It's not clear here these are in a grandchild node.

Every afe port/dai has some board specifics, to allow that we need dai
specific child nodes.
Yes, but what I mean is #sound-dai-cells is a property of the dais
node, but reg and qcom,sd-lines are properties of child nodes under
the dais node. It is evident in the example, but not without the
example. >
Also, anywhere with reg needs #address-cells and #size-cells in the parent node.

Yep, #address-cells and #size-cells are missing, Will add them along with some notes.