Re: [PATCH v3 4/5] soc/tegra: pmc: Use of_clk_get_parent_count() instead of open coding

From: Daniel Lezcano
Date: Mon Apr 30 2018 - 09:44:33 EST


On Wed, Apr 18, 2018 at 04:50:04PM +0200, Geert Uytterhoeven wrote:
> As of_clk_get_parent_count() returns zero on failure, while
> of_count_phandle_with_args() might return a negative error code, this
> also fixes the issue of possibly using a very big number in the
> allocation below.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
> This depends on "[PATCH v3 1/5] clk: Extract OF clock helpers in
> <linux/of_clk.h>".
>
> v3:
> - Add Acked-by,
>
> v2:
> - of_clk_get_parent_count() was moved to <linux/of_clk.h>.
> ---

Reviewed-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>




<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog