[PATCH 4.9 47/61] crypto: drbg - set freed buffers to NULL

From: Greg Kroah-Hartman
Date: Mon Apr 30 2018 - 15:27:07 EST

4.9-stable review patch. If anyone has any objections, please let me know.


From: Stephan Mueller <smueller@xxxxxxxxxx>

commit eea0d3ea7546961f69f55b26714ac8fd71c7c020 upstream.

During freeing of the internal buffers used by the DRBG, set the pointer
to NULL. It is possible that the context with the freed buffers is
reused. In case of an error during initialization where the pointers
do not yet point to allocated memory, the NULL value prevents a double

Cc: stable@xxxxxxxxxxxxxxx
Fixes: 3cfc3b9721123 ("crypto: drbg - use aligned buffers")
Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx>
Reported-by: syzbot+75397ee3df5c70164154@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

crypto/drbg.c | 2 ++
1 file changed, 2 insertions(+)

--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -1134,8 +1134,10 @@ static inline void drbg_dealloc_state(st
if (!drbg)
+ drbg->Vbuf = NULL;
drbg->V = NULL;
+ drbg->Cbuf = NULL;
drbg->C = NULL;
drbg->scratchpadbuf = NULL;