Re: [PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text

From: Randy Dunlap
Date: Tue May 01 2018 - 00:23:55 EST


On 04/30/2018 08:00 PM, Manivannan Sadhasivam wrote:
> 1. Fix Kconfig dependency for Actions Semi S900 pinctrl driver which
> generates below warning in x86:
>
> WARNING: unmet direct dependencies detected for PINCTRL_OWL
> Depends on [n]: PINCTRL [=y] && (ARCH_ACTIONS || COMPILE_TEST [=n]) && OF [=n]
> Selected by [y]:
> - PINCTRL_S900 [=y] && PINCTRL [=y]
>
> 2. Add help text for OWL pinctrl driver
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> drivers/pinctrl/actions/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/actions/Kconfig b/drivers/pinctrl/actions/Kconfig
> index 1c7309c90f0d..ede97cdbbc12 100644
> --- a/drivers/pinctrl/actions/Kconfig
> +++ b/drivers/pinctrl/actions/Kconfig
> @@ -1,12 +1,14 @@
> config PINCTRL_OWL
> - bool
> + bool "Actions Semi OWL pinctrl driver"
> depends on (ARCH_ACTIONS || COMPILE_TEST) && OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> + help
> + Say Y here to enable Actions Semi OWL pinctrl driver
>
> config PINCTRL_S900
> bool "Actions Semi S900 pinctrl driver"
> - select PINCTRL_OWL
> + depends on PINCTRL_OWL
> help
> Say Y here to enable Actions Semi S900 pinctrl driver
>


--
~Randy