Re: [PATCH 4/4] dt-bindings: mfd: max8998: Add charger subnode binding

From: Sebastian Reichel
Date: Tue May 01 2018 - 08:45:47 EST


Hi,

On Fri, Apr 27, 2018 at 06:03:02PM +0200, PaweÅ Chmiel wrote:
> This patch adds devicetree bindings documentation for
> battery charging controller as the subnode of MAX8998 PMIC.
> It's based on current behavior of driver.
>
> Fixes: ee999fb3f17f ("mfd: max8998: Add support for Device Tree")
> Signed-off-by: PaweÅ Chmiel <pawel.mikolaj.chmiel@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/max8998.txt | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max8998.txt b/Documentation/devicetree/bindings/mfd/max8998.txt
> index 23a3650ff2a2..f95610afb57f 100644
> --- a/Documentation/devicetree/bindings/mfd/max8998.txt
> +++ b/Documentation/devicetree/bindings/mfd/max8998.txt
> @@ -50,6 +50,21 @@ Additional properties required if max8998,pmic-buck2-dvs-gpio is defined:
> - max8998,pmic-buck2-dvs-voltage: An array of 2 voltage values in microvolts
> for buck2 regulator that can be selected using dvs gpio.
>
> +Charger: Configuration for battery charging controller should be added
> +inside a child node named 'charger'.
> + Required properties:
> + - max8998,charge-eoc: Setup "End of Charge". If value equals 0,
> + remain value set from bootloader or default value will be used.
> + Valid values: 0, 10 - 45
> +
> + - max8998,charge-restart: Setup "Charge Restart Level". If value equals 0,
> + remain value set from bootloader or default value will be used.
> + Valid values: -1, 0, 100, 150, 200
> +
> + - max8998,charge-timeout: Setup "Charge Full Timeout". If value equals 0,
> + remain value set from bootloader or default value will be used.
> + Valid values: -1, 0, 5, 6, 7

What are those values? seconds?

> +
> Regulators: All the regulators of MAX8998 to be instantiated shall be
> listed in a child node named 'regulators'. Each regulator is represented
> by a child node of the 'regulators' node.
> @@ -99,6 +114,13 @@ Example:
> max8998,pmic-buck2-dvs-gpio = <&gpx0 0 3 0 0>; /* SET3 */
> max8998,pmic-buck2-dvs-voltage = <1350000>, <1300000>;
>
> + /* Charger configuration */
> + charger {
> + max8998,charge-eoc = <0>;
> + max8998,charge-restart = <(-1)>;
> + max8998,charge-timeout = <7>;
> + };
> +
> /* Regulators to instantiate */
> regulators {
> ldo2_reg: LDO2 {
> --
> 2.7.4
>

Attachment: signature.asc
Description: PGP signature