Re: [PATCH 2/5] regulator: add dummy of_find_regulator_by_node

From: Mark Brown
Date: Tue May 01 2018 - 16:41:18 EST


On Tue, May 01, 2018 at 09:00:11PM +0800, changbin.du@xxxxxxxxx wrote:
> From: Changbin Du <changbin.du@xxxxxxxxx>
>
> If device tree is not enabled, of_find_regulator_by_node() should have
> a dummy function since the function call is still there.
>
> Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>

This appears to have no obvious connection with the cover letter for the
series... The first question here is if this is something best fixed
with a stub or by fixing the users - is the lack of a stub pointing out
some bugs in them? I'm a bit worried about how we've been managing to
avoid any build test issues here though, surely the various builders
would have spotted a problem?

Attachment: signature.asc
Description: PGP signature