Re: [PATCH 2/3] random: Return nbytes filled from hw RNG

From: Theodore Y. Ts'o
Date: Tue May 01 2018 - 20:19:34 EST


On Wed, May 02, 2018 at 09:33:39AM +1000, Tobin C. Harding wrote:
> Currently the function get_random_bytes_arch() has return value 'void'.
> If the hw RNG fails we currently fall back to using get_random_bytes().
> This defeats the purpose of requesting random material from the hw RNG
> in the first place.
>
> There are currently no intree users of get_random_bytes_arch().
>
> Only get random bytes from the hw RNG, make function return the number
> of bytes retrieved from the hw RNG.
>
> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Tobin C. Harding <me@xxxxxxxx>

Acked-by: Theodore Ts'o <tytso@xxxxxxx>