Re: [PATCH] h8300: switch to NO_BOOTMEM

From: Rob Herring
Date: Tue May 01 2018 - 22:34:11 EST


On Fri, Mar 16, 2018 at 4:33 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> Commit 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc")
> inadvertently switched the DT unflattening allocations from memblock to
> bootmem which doesn't work because the unflattening happens before
> bootmem is initialized. Swapping the order of bootmem init and
> unflattening could also fix this, but removing bootmem is desired. So
> enable NO_BOOTMEM on h8300 like other architectures have done.
>
> Fixes: 0fa1c579349f ("of/fdt: use memblock_virt_alloc for early alloc")
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> I haven't seen any reports, but 4.16 is likely broken. This is compile
> tested only.
>
> Moving unflattening after bootmem_init should also work if a smaller
> change for 4.16 is desired.

Ping! Someone going to pick this up?

Rob