Re: [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency

From: Martin K. Petersen
Date: Tue May 01 2018 - 23:32:25 EST

Next message: Martin K. Petersen: "Re: [PATCH] scsi: esas2r: fix spelling mistake: "asynchromous" -> "asynchronous""
Previous message: Baolin Wang: "Re: [PATCH 1/2] i2c: sprd: Prevent i2c accesses after suspend is called"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Colin,

> The sanity check on u->in_connection_align_insertion_frequency is
> being performed twice and hence the first check can be removed since
> it is redundant. Cleans up cppcheck warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if'
> condition is always true.

Applied to 4.18/scsi-queue. Thanks.

--
Martin K. Petersen Oracle Linux Engineering

Next message: Martin K. Petersen: "Re: [PATCH] scsi: esas2r: fix spelling mistake: "asynchromous" -> "asynchronous""
Previous message: Baolin Wang: "Re: [PATCH 1/2] i2c: sprd: Prevent i2c accesses after suspend is called"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]