RE: [PATCH v6 01/11] perf/x86/intel/pt: Move Intel-PT MSR bit definitions to a public header

From: Kang, Luwei
Date: Wed May 02 2018 - 03:42:01 EST


> > Intel Processor Trace virtualization enabling in guest need to use
> > these MSR bits, so move them to public header msr-index.h.
> > Introduce RTIT_CTL_FABRIC_EN and sync the definitions to latest spec.
>
> You forgot to Cc the maintainers.
>
> Also, this patch does 2 things, I think we have a rule that says that's a bad thing.

I will split it into two patches, one patch to make these #define in a public header and another patch to add new bits for Intel Processor Trace MSRs. Thank for the review.

Thanks,
Luwei Kang