Re: [PATCH 2/2] clk: qcom: Add video clock controller driver for SDM845

From: Nischal, Amit
Date: Wed May 02 2018 - 03:56:51 EST




On 5/2/2018 3:11 AM, Stephen Boyd wrote:
Quoting Amit Nischal (2018-04-24 06:32:51)
Add support for the video clock controller found on SDM845
based devices. This would allow video drivers to probe and
control their clocks.

Signed-off-by: Amit Nischal <anischal@xxxxxxxxxxxxxx>
Driver looks small and good. Only concern is that there aren't resets
defined, but the binding says there are resets. Will you add them?
Thanks for the review.
As of now, there are no resets defined for VIDEOCC. So I will move
the #reset-cells tooptional property in the dt-binding.
Same will be updated in the next patch series.

I'm going to wait for the respin on the dts binding anyway.
Yes, I will send the next patch series soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html