Re: [PATCH 1/2] dt-bindings: add MediaTek XS-PHY binding
From: Rob Herring
Date: Wed May 02 2018 - 08:42:12 EST
On Wed, May 2, 2018 at 2:04 AM, Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> wrote:
> Hi Rob,
> On Tue, 2018-05-01 at 09:24 -0500, Rob Herring wrote:
>> On Wed, Apr 25, 2018 at 03:45:28PM +0800, Chunfeng Yun wrote:
>> > Add a DT binding documentation of XS-PHY for MediaTek SoCs
>> > with USB3.1 GEN2 controller
[...]
>> > + reg = <0 0x11c43000 0 0x0200>;
>> > + mediatek,src-ref-clk-mhz = <26>;
>> > + mediatek,src-coef = <17>;
>> > + #address-cells = <2>;
>> > + #size-cells = <2>;
>>
>> Really need 64-bit sizes?
> Just an example, 32-bit is also ok, but it's better to use the same
> value as the root node
Why is it better?
It is unnecessary bloat and it is better to limit the range of child
nodes using ranges.
Rob