Re: [PATCH] mfd: qcom-spmi-pmic: Add support for pm8005,pm8998,pmi8998

From: Stephen Boyd
Date: Wed May 02 2018 - 12:29:43 EST


Quoting Doug Anderson (2018-04-23 22:26:29)
>
> > static const struct of_device_id pmic_spmi_id_table[] = {
> > { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
> > @@ -54,7 +57,10 @@ static const struct of_device_id pmic_spmi_id_table[] = {
> > { .compatible = "qcom,pmi8994", .data = (void *)PMI8994_SUBTYPE },
> > { .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE },
> > { .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE },
> > + { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
> > + { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
> > { .compatible = "qcom,pm8909", .data = (void *)PM8909_SUBTYPE },
> > + { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
>
> nit: It appears that the above table was previously sorted by SUBTYPE
> ID. Could you perhaps move your 3 new PMICs to the bottom to maintain
> this? Other than that, you can add my Reviewed-by if you would like
> (not that I have _any_ real expertise on SPMI, so might not be worth
> it).

Ok. I'll change the order and resend the patch with the reviewed-by
tags.