Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

[Doug Anderson]

Hi,

On Fri, Apr 13, 2018 at 7:50 PM, David Collins <collinsd@xxxxxxxxxxxxxx> wrote:
> +- vdd_l26-supply
> +- vdd_lvs1_lvs2-supply
> +- vdd_lvs1_lvs2-supply
> +       Usage:      optional (PM8998 only)
> +       Value type: <phandle>
> +       Definition: phandle of the parent supply regulator of one or more of the
> +                   regulators for this PMIC.

One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice.

Also on the schematics (and in the PM8998 datasheet) I have this is
"VIN_LVS_1_2".  It seems like you should be consistent here and call
this "vin-lvs-1-2-supply".

-Doug