Re: [RFC] perf record: dead code perf_event__synthesize_id_index()

From: Jiri Olsa
Date: Wed May 02 2018 - 12:57:45 EST


On Wed, May 02, 2018 at 04:38:33PM +0000, Stephane Eranian wrote:
> Hi,
>
> It looks like perf_event__synthesize_id_index() is dead code in the current
> tip
> tree. I don't see any invocation of the function anywhere in perf.I
> understand why
> you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX
> because some perf.data file may have this user-level record type. But the
> synthesize code is not needed anymore, in my opinion.
>
> Shouldn't we remove this code?

looks like there never was any user of it, probably some
preparation for follow up that haven't happened yet.. Adrian?

jirka