Re: [PATCH v8 11/13] arm64: topology: enable ACPI/PPTT based CPU topology

[Jeremy Linton]

Hi,

On 05/02/2018 03:24 AM, Rafael J. Wysocki wrote:
> On Tue, May 1, 2018 at 4:46 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> > On 26/04/18 00:31, Jeremy Linton wrote:
> > > Propagate the topology information from the PPTT tree to the
> > > cpu_topology array. We can get the thread id and core_id by assuming
> > > certain levels of the PPTT tree correspond to those concepts.
> > > The package_id is flagged in the tree and can be found by calling
> > > find_acpi_cpu_topology_package() which terminates
> > > its search when it finds an ACPI node flagged as the physical
> > > package. If the tree doesn't contain enough levels to represent
> > > all of the requested levels then the root node will be returned
> > > for all subsequent levels.
> >
> > Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> >
> > [..]
> >
> > > @@ -304,6 +345,8 @@ void __init init_cpu_topology(void)
> > >         * Discard anything that was parsed if we hit an error so we
> > >         * don't use partial information.
> > >         */
> > > -     if (of_have_populated_dt() && parse_dt_topology())
> > > +     if ((!acpi_disabled) && parse_acpi_topology())
> >
> > [nit] not sure if extra () is need above,
>
> No, it isn't.
>
> > but I am fine either way.
>
> The redundant parens need to go away, really.

Yah, I missed this one, is there a linter everyone is using that finds 
these?

Thanks,