Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

[Zumeng Chen]

On 2018å05æ03æ 01:32, Michael Chan wrote:
> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen <zumeng.chen@xxxxxxxxx> wrote:
> > On 2018å05æ02æ 13:12, Michael Chan wrote:
> > > On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.chen@xxxxxxxxx> wrote:
> > >
> > > > diff --git a/drivers/net/ethernet/broadcom/tg3.h
> > > > b/drivers/net/ethernet/broadcom/tg3.h
> > > > index 3b5e98e..c61d83c 100644
> > > > --- a/drivers/net/ethernet/broadcom/tg3.h
> > > > +++ b/drivers/net/ethernet/broadcom/tg3.h
> > > > @@ -3102,6 +3102,7 @@ enum TG3_FLAGS {
> > > >           TG3_FLAG_ROBOSWITCH,
> > > >           TG3_FLAG_ONE_DMA_AT_ONCE,
> > > >           TG3_FLAG_RGMII_MODE,
> > > > +       TG3_FLAG_HALT,
> > > I think you should be able to use the existing INIT_COMPLETE flag
> >
> > No,  it will bring the uncertain factors into the existed complicate logic
> > of INIT_COMPLETE.
> > And I think it's very simple logic here to fix the meaningless hw_stats
> > reading and the problem
> > of commit f5992b72. I even suspect if you have read INIT_COMPLETE related
> > codes carefully.
> We should use an existing flag whenever appropriate

I disagree. This is sort of blahblah...
> , instead of adding
> yet another flag to do similar things. I've looked at the code briefly
> and believe that INIT_COMPLETE will work.

When we fix a problem, we'd better think if we introduce a new one.

>    If you think it won't work,
> please be specific and point out why it won't work.  Thanks.

I don't care if it work or not, I directly feel it's a bad idea.
INIT_COMPLETE include a lot of network stuffs, it's not simple hardware 
reset related.

Here again,

My fix logic is very simple to fix the problem I met, I think this is 
how Linux works together
with such a lot of thing, which means clear,  simple, and robust for 
every unit, we re-unite
them eco-systematically.

Finally, it's yours, so be it.

Cheers,
Zumeng