Re: [PATCH v2 06/10] PCI: Introduce devm_of_pci_get_host_bridge_resources()

From: Vladimir Zapolskiy
Date: Thu May 03 2018 - 03:15:32 EST


On 04/30/2018 08:48 AM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> of_pci_get_host_bridge_resources() allocates the resource structures it
> fills dynamically, but none of its callers care to release them so far.
> Rather than requiring everyone to do this explicitly, introduce a
> managed version of that service. This differs API-wise only in taking a
> reference to the associated device, rather than to the device tree node.
>
> As of_pci_get_host_bridge_resources() is an exported interface, we
> cannot simply drop it at this point. After converting all in-tree users
> to the new API, we will phase out the unmanaged one.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>

Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>
Tested-by: Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx>

--
With best wishes,
Vladimir