Re: [PATCH v2 2/3] intel-iommu: generalize __mapping_notify_one()

From: Peter Xu
Date: Thu May 03 2018 - 22:24:07 EST


On Thu, May 03, 2018 at 03:14:24PM +0200, Joerg Roedel wrote:
> On Wed, Apr 18, 2018 at 04:39:52PM +0800, Peter Xu wrote:
> > Generalize this new helper to notify one newly created mapping on one
> > single IOMMU. We can further leverage this helper in the next patch.
>
> You introduce the function, you do not generalize it. Please fix that in
> the subject and description.
>
> Also, please drop patch 1, I don't like this pr_debug stuff in the
> code. And please also fix the subject line in general to match the form:
>
> iommu/vt-d: _I_ntroduce __mapping_notify_one()
>
> When that is done, please re-send.

Will do. Thanks, Joerg.

--
Peter Xu