Re: [PATCH 04/15] powerpc/powernv: opal-kmsg use flush fallback from console code

From: Michael Ellerman
Date: Fri May 04 2018 - 01:16:55 EST


Nicholas Piggin <npiggin@xxxxxxxxx> writes:

> Use the more refined and tested event polling loop from opal_put_chars
> as the fallback console flush in the opal-kmsg path. This loop is used
> by the console driver today, whereas the opal-kmsg fallback is not
> likely to have been used for years.
>
> Use WARN_ONCE rather than a printk when the fallback is invoked to
> prepare for moving the console flush into a common function.

Do we want to add a WARN in that path? If we're panicking things might
get worse if we WARN (which takes a trap).

cheers