Re: [PATCH 1/9] R3Di and SBZ quirk entires + alt firmware loading

From: Takashi Sakamoto
Date: Fri May 04 2018 - 04:32:32 EST


Hi,

On May 04 2018 13:30, Connor McAdams wrote:
Sorry for sending these twice, I made a formatting mistake in the
first series, and they would not apply properly. Hopefully these do
not show up as spam because of this.

I went through and fixed them all individually and re-committed them,
but kept the same commit messages. I still have a lot to learn.

For this case, please use '--subject-prefix' option for git-format-patch. Like:

$ git format-patch --subject-prefix='PATCH v2'


Additionally, it's preferable to add 'ALSA: hda/ca0132: ' prefix for each patch. Like:

'ALSA: hda/ca0132: R3Di and SBZ quirk entires + alt firmware loading'


Furthermore, when posting several patches as a one series, it's preferable to post cover letter as well. Like:

$ git format-patch --cover-letter
0000-cover-letter.patch
...

Of course, it's better to write enough information in the cover letter. For its content, please refer to cover letters by the other developers in alsa-devel archive.
http://mailman.alsa-project.org/pipermail/alsa-devel/


Thanks

Takashi Sakamoto