Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)

[Marcel Ziswiler]

Hi Krzysztof

On Fri, 2018-05-04 at 11:19 +0200, Stefan Agner wrote:
> On 03.05.2018 17:08, Krzysztof Kozlowski wrote:
> > Colibri-T20 can come in 256 MB RAM (with 512 MB NAND) or 512 MB RAM
> > (with 1024 MB NAND) flavors.  Add support for the 256 MB version on
> > Iris
> > evaluation board.
> 
> To we really need to specify memory size these days? I think all
> common
> boot loaders fill the memory node anyway.
> 
> arch/arm/boot/dts/imx6qdl-apalis.dtsi:
> 	/* Will be filled by the bootloader */
> 	memory@10000000 {
> 		reg = <0x10000000 0>;
> 	};

Yes, both mainline as well as our downstream U-Boot do actually set the
memory node.

In the past some people used to set it to the smallest SKU's memory
size just to be on the safe side.

However lately it is agreed that the memory node should no longer even
be present as can be seen from e.g. arch/arm/boot/dts/tegra30-
apalis.dtsi resp. tegra30-apalis-eval.dts.

> I think we should just rename tegra20-colibri-512.dtsi =>
> tegra20-colibri.dtsi and tegra20-iris-512.dts => tegra20-iris.dts
> avoid confusion and add such an empty node.

I would rather suggest going to the regular SoC, module, carrier naming
convention making it tegra20-colibri-iris.dts instead.

> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Fix memory size in tegra20-colibri-256.dtsi (was working fine
> > because
> >    my bootloader uses mem= argument).
> 
> What boot loader are you using? You even can omit mem= if your boot
> loader fills the memory node properly.

Yes, using mem= should only be used to force memory size for test
purpose [1].

> --
> Stefan

[1] https://www.kernel.org/doc/html/v4.14/admin-guide/kernel-parameters
.html

Cheers

Marcel