Re: [RFC] sched/core: Don't schedule threads on pre-empted vcpus

[Peter Zijlstra]

On Wed, May 02, 2018 at 01:52:10PM -0700, Rohit Jain wrote:
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 5e10aae..75d1ecf 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4033,6 +4033,9 @@ int idle_cpu(int cpu)
>  		return 0;
>  #endif
>  
> +	if (vcpu_is_preempted(cpu))
> +		return 0;
> +
>  	return 1;
>  }

Basically OK with this, but did you consider idle_cpu() usage outside of
select_idle_sibling()?

For instance, I think got_nohz_idle_kick() isn't quite right with this
on. Similarly for scheduler_tick(), that wants the actual idle state.