Re: [PATCH v3 2/3] resource: add walk_system_ram_res_rev()

From: Borislav Petkov
Date: Fri May 04 2018 - 06:16:46 EST


On Thu, Apr 26, 2018 at 09:22:04PM +0800, Baoquan He wrote:
> I noticed maintainers merged patches with this Message-ID, could you
> tell how to get this Message-ID?

https://en.wikipedia.org/wiki/Message-ID

> This is not a thing that one is top down, the other is bottom up. For
> us, they might be so different on details of code, for customers, they
> just think them as a same thing. They may say I just get a new machine,
> and still do kexec loading, why these top-down, bottom-up things come
> up.

So if I read the above correctly, it doesn't matter whether top-down or
bottom-up.

> And this is not causing code churn. You can see that by replacing
> pointer operation with list_head, code in kernel/resource.c related to
> child list iteration is much easier to read,

Now *this* is starting to sound like some reason "why". If it is better
readability, then say so in the commit message.

It still doesn't justify adding walk_system_ram_res_rev() though.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--