Re: [PATCH] block: add verifier for cmdline partition

[Jens Axboe]

On 5/4/18 1:07 AM, Caizhiyong wrote:
>> -----Original Message-----
>> From: Wang YanQing [mailto:udknight@xxxxxxxxx]
>> Sent: Thursday, May 03, 2018 7:18 PM
>> To: axboe@xxxxxxxxx
>> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; pombredanne@xxxxxxxx;
>> tglx@xxxxxxxxxxxxx; Caizhiyong <caizhiyong@xxxxxxxxxxxxx>; linux-
>> block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: [PATCH] block: add verifier for cmdline partition
>>
>> I meet strange filesystem corruption issue recently, the reason
>> is there are overlaps partitions in cmdline partition argument.
>>
>> This patch add verifier for cmdline partition, then if there are
>> overlaps partitions, cmdline_partition will return error and log
>> a error message.
>>
> 
> Partition overlap was intentionally designed in this cmdline partition.
> some time, the cmdline partition save raw data(not filesystem), the overlap makes data  access very convenient.
> 
> reference  http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html

Might make sense to warn about it at least, it can be very surprising if
it happens inadvertently.

-- 
Jens Axboe