Re: [PATCH] net: sched: cls: fix a potential missing-check bug

From: David Miller
Date: Fri May 04 2018 - 13:13:03 EST


From: Wenwen Wang <wang6495@xxxxxxx>
Date: Fri, 4 May 2018 02:05:05 -0500

> Given that gen_tunnel() may return a value larger than 255 based on
> data, the new value of f->res.classid should be re-checked.

gen_tunnel() may not ever return a value larger than 255.

data->tgenerator is a u8 and therefore can never take on a value
outside of the range of 0 to 255.

I'm not applying this patch, sorry.