Re: [PATCH] kernel/signal: Remove no longer required irqsave/restore

From: Eric W. Biederman
Date: Fri May 04 2018 - 13:17:35 EST


Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:

> On 2018-05-04 11:59:08 [-0500], Eric W. Biederman wrote:
>> Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes:
>> > From: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> â
>> > This long-term fix has been made in commit 4abf91047cf ("rtmutex: Make >
>> > wait_lock irq safe") for different reason.
>>
>> Which tree has this change been made in? I am not finding the commit
>> you mention above in Linus's tree.
>
> I'm sorry, it should have been commit b4abf91047cf ("rtmutex: Make
> wait_lock irq safe").

Can you fix that in your patch description and can you also up the
description of rcu_read_unlock?

If we don't need to jump through hoops it looks very reasonable to
remove this unnecessary logic. But we should fix the description
in rcu_read_unlock that still says we need these hoops.

Eric