Re: [PATCH net] net: phy: sfp: fix the BR,min computation

From: David Miller
Date: Fri May 04 2018 - 13:31:31 EST


From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Date: Fri, 4 May 2018 17:10:54 +0200

> In an SFP EEPROM values can be read to get information about a given SFP
> module. One of those is the bitrate, which can be determined using a
> nominal bitrate in addition with min and max values (in %). The SFP code
> currently compute both BR,min and BR,max values thanks to this nominal
> and min,max values.
>
> This patch fixes the BR,min computation as the min value should be
> subtracted to the nominal one, not added.
>
> Fixes: 9962acf7fb8c ("sfp: add support for 1000Base-PX and 1000Base-BX10")
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

Applied and queued up for -stable, thanks.