Re: [PATCH v3][RESEND] media: i2c: tda1997: replace codec to component

From: Mauro Carvalho Chehab
Date: Fri May 04 2018 - 14:58:44 EST


Em Mon, 23 Apr 2018 13:59:32 -0700
Tim Harvey <tharvey@xxxxxxxxxxxxx> escreveu:

> On Mon, Apr 23, 2018 at 9:52 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Mon, Apr 23, 2018 at 09:44:17AM -0700, Tim Harvey wrote:
> >
> >> Could you add some detail to the commit explaining why we need to
> >> replace codec to component? I don't really know what that means.
> >> Please refer to a commit if the ASoC API is changing in some way we
> >> need to catch up with.
> >
> > This is a big transition in the ASoC API which is nearing completion -
> > this driver is one of the last users of the CODEC struct, we've (well,
> > mainly Morimoto-san) been migrating things away from it to the more
> > general purpose component. There's no one commit to point at really as
> > the two have coexisted for a while and we won't be able to finally
> > remove the CODEC struct until all the drivers have transitioned away.
>
> Mark,
>
> Ok - thanks for the explanation!
>
> Kuninori,
>
> Sorry this took so long to get to. Tested on a GW5404
>
> Tested-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Acked-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>

In order to keep it together with the patches doing the removal of
the old API, it is probably better to apply this via ALSA tree:

Acked-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>

>
> Regards,
>
> Tim



Thanks,
Mauro