Re: [PATCH v5 5/7] gpio: pca953x: fix address calculation for pcal6524
From: Andy Shevchenko
Date: Sat May 05 2018 - 06:30:06 EST
On Fri, May 4, 2018 at 10:30 AM, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote:
>> Am 02.05.2018 um 14:35 schrieb H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>:
>>> Suggested-by ?
>>
>> Detecting that we need to adjust the registers generally was from me,
>> but your suggestion of an improved formula should of course be mentioned
>> and appreciated!
>>
>> I'll think about a good formulation for v6.
>
> Would the following commit message be ok for you?
Yes, it's perfect.
>
> ...
>
> Therefore, we have to add code to the 24 bit accessor functions
> that adjusts the register number for these exended registers.
>
> The formula finally used was developed and proposed by
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx>.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko