Re: moving affs + RDB partition support to staging?

From: Al Viro
Date: Sun May 06 2018 - 17:33:01 EST


On Sun, May 06, 2018 at 09:46:23PM +0100, Al Viro wrote:

> I'm fixing that pile of crap (along with the NFS exports
> one and, hopefully, rename mess as well). HOWEVER, I am not going
> to take over the damn thing - David has violated the 11th
> commandment (Thou Shalt Never Volunteer), so he gets to joy of
> learning that codebase and taking care of it from now on.

Same scenario on link(2) ends up with
* ST_LINKFILE created, inserted into the link chain and left around,
without being present in any hash chain
* target becoming positive hashed dentry, as if link(2) has succeeded,
so dcache lookups will be finding it (for a while)
* unlink(2) on source will have very interesting effects, what with
the attempts to move ST_FILE entry into the directory presumed to
contain ST_LINKFILE one, removing ST_LINKFILE from it at the same time.