Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

From: Tobin C. Harding
Date: Sun May 06 2018 - 22:56:11 EST


On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote:
> From: Andrea Greco <a.greco@xxxxxxxxx>
>
> If com20020 clock is major of 40Mhz SLOWARB bit is requested.
>
> Signed-off-by: Andrea Greco <a.greco@xxxxxxxxx>
> ---
> drivers/net/arcnet/com20020.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c
> index f09ea77dd6a8..abd32ed8ec9b 100644
> --- a/drivers/net/arcnet/com20020.c
> +++ b/drivers/net/arcnet/com20020.c
> @@ -102,6 +102,10 @@ int com20020_check(struct net_device *dev)
> lp->setup = lp->clockm ? 0 : (lp->clockp << 1);
> lp->setup2 = (lp->clockm << 4) | 8;
>
> + // If clock is major of 40Mhz, SLOWARB bit must be set

/* C89 style comments please :) */


Hope this helps,
Tobin.