Re: [PATCH v3 1/3] alpha: Use OPTIMIZE_INLINING instead of asm/compiler.h

[James Hogan]

On Sun, May 06, 2018 at 12:33:21PM -0700, Matt Turner wrote:
> On Tue, Apr 17, 2018 at 3:11 AM, James Hogan <jhogan@xxxxxxxxxx> wrote:
> > Use CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING and CONFIG_OPTIMIZE_INLINING
> > instead of undefining the inline macros in the alpha specific
> > asm/compiler.h. This is to allow asm/compiler.h to become a general
> > header that can be used for overriding linux/compiler*.h.
> >
> > A build of alpha's defconfig on GCC 7.3 before and after this series
> > (i.e. this commit and "compiler.h: Allow arch-specific overrides" which
> > includes asm/compiler.h from linux/compiler_types.h) results in the
> > following size differences, which appear harmless to me:
> >
> > $ ./scripts/bloat-o-meter vmlinux.1 vmlinux.2
> > add/remove: 1/1 grow/shrink: 3/0 up/down: 264/-348 (-84)
> > Function                                     old     new   delta
> > cap_bprm_set_creds                          1496    1664    +168
> > cap_issubset                                   -      68     +68
> > flex_array_put                               328     344     +16
> > cap_capset                                   488     500     +12
> > nonroot_raised_pE.constprop                  348       -    -348
> > Total: Before=5823709, After=5823625, chg -0.00%
> >
> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: James Hogan <jhogan@xxxxxxxxxx>
> > Cc: Richard Henderson <rth@xxxxxxxxxxx>
> > Cc: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Matt Turner <mattst88@xxxxxxxxx>
> > Cc: linux-alpha@xxxxxxxxxxxxxxx
> 
> Looks fine to me.
> 
> Acked-by: Matt Turner <mattst88@xxxxxxxxx>

Thanks

> 
> Should I take it through the alpha tree?

I'll take all 3 through the MIPS tree if thats okay with you, as its a
prerequisite to allowing MIPS to override stuff in linux/compiler-gcc.h
using asm/compiler.h, which is needed to fix build breakage in 4.17.

Thanks
James

Attachment: signature.asc
Description: PGP signature