Re: [PATCH V2 01/10] ASoC: amd: dma config parameters changes

From: Mukunda,Vijendar
Date: Mon May 07 2018 - 06:19:28 EST




On Monday 07 May 2018 11:57 AM, Mukunda,Vijendar wrote:


On Wednesday 02 May 2018 02:19 AM, Vijendar Mukunda wrote:
Added dma configuration parameters to rtd structure.
Moved dma configuration parameters initialization to
hw_params callback.
Removed hard coding in prepare and trigger callbacks.

Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
---
v1->v2 : Fixed capture stream wrong channel assignment
ÂÂÂÂ added comments in dma trigger api
 sound/soc/amd/acp-pcm-dma.c | 103 ++++++++++++++++++--------------------------
 sound/soc/amd/acp.h | 5 +++
 2 files changed, 48 insertions(+), 60 deletions(-)

Hi Mark,

In this series, patches 01/10 to 09/10 are good to go from Dan, could you please review and merge them.

For 10/10 please let us know your thoughts on it, discussion reference:
https://lkml.org/lkml/2018/5/4/23

Thanks,
Vijendar


Hi Mark,

After comment from Dan on 10/10 , re-spinning the patch series by
adding Reviewed-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>

Thanks,
Vijendar