Re: [PATCH v2] ARM: dts: tegra: Add support for 256 MB Colibri-T20 (plus such board on Iris)
From: Rob Herring
Date: Mon May 07 2018 - 12:58:22 EST
On Thu, May 03, 2018 at 05:08:32PM +0200, Krzysztof Kozlowski wrote:
> Colibri-T20 can come in 256 MB RAM (with 512 MB NAND) or 512 MB RAM
> (with 1024 MB NAND) flavors. Add support for the 256 MB version on Iris
> evaluation board.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> ---
>
> Changes since v1:
> 1. Fix memory size in tegra20-colibri-256.dtsi (was working fine because
> my bootloader uses mem= argument).
> ---
> Documentation/devicetree/bindings/arm/tegra.txt | 1 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/tegra20-colibri-256.dtsi | 11 +
> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 531 +--------------------
> ...gra20-colibri-512.dtsi => tegra20-colibri.dtsi} | 4 -
> arch/arm/boot/dts/tegra20-iris-256.dts | 10 +
> arch/arm/boot/dts/tegra20-iris-512.dts | 98 +---
> ...gra20-iris-512.dts => tegra20-iris-common.dtsi} | 11 +-
> 8 files changed, 31 insertions(+), 636 deletions(-)
> create mode 100644 arch/arm/boot/dts/tegra20-colibri-256.dtsi
> copy arch/arm/boot/dts/{tegra20-colibri-512.dtsi => tegra20-colibri.dtsi} (99%)
> create mode 100644 arch/arm/boot/dts/tegra20-iris-256.dts
> copy arch/arm/boot/dts/{tegra20-iris-512.dts => tegra20-iris-common.dtsi} (85%)
>
> diff --git a/Documentation/devicetree/bindings/arm/tegra.txt b/Documentation/devicetree/bindings/arm/tegra.txt
> index 32f62bb7006d..d304574ae441 100644
> --- a/Documentation/devicetree/bindings/arm/tegra.txt
> +++ b/Documentation/devicetree/bindings/arm/tegra.txt
> @@ -49,6 +49,7 @@ board-specific compatible values:
> toradex,apalis_t30-eval
> toradex,apalis-tk1
> toradex,apalis-tk1-eval
> + toradex,colibri_t20-256
NAK unless there are changes beyond the memory size. Otherwise, just use
the existing string or deprecate the existing one for a new one without
the memory size. I prefer the less churn of the former option.
> toradex,colibri_t20-512
> toradex,colibri_t30
> toradex,colibri_t30-eval-v3