Re: [PATCH 14/24] selftests: kvm: return Kselftest Skip code for skipped tests
From: Shuah Khan
Date: Mon May 07 2018 - 15:41:48 EST
On 05/07/2018 05:46 AM, Paolo Bonzini wrote:
> On 05/05/2018 03:13, Shuah Khan (Samsung OSG) wrote:
>> When kvm test is skipped because of unmet dependencies and/or unsupported
>> configuration, it exits with error which is treated as a fail by the
>> Kselftest framework. This leads to false negative result even when the test
>> could not be run.
>>
>> Change it to return kselftest skip code when a test gets skipped to clearly
>> report that the test could not be run.
>>
>> Change it to use ksft_exit_skip() when the test is skipped. In addition,
>> refine test_assert() message to include strerror() string and add explicit
>> check for root user to clearly identofy non-root user skip case.
>
> Root should not be needed.
Will remove the root check and send v2.
>
> Otherwise
>
> Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>
thanks,
-- Shuah