Re: [PATCH 2/2] net: nixge: Address compiler warnings about signedness

From: David Miller
Date: Mon May 07 2018 - 23:30:44 EST


From: Moritz Fischer <mdf@xxxxxxxxxx>
Date: Fri, 4 May 2018 10:18:34 -0700

> Fixes the following warnings:
> warning: pointer targets in passing argument 1 of
> ʽis_valid_ether_addrʼ differ in signedness [-Wpointer-sign]
> if (mac_addr && is_valid_ether_addr(mac_addr)) {
> ^~~~~~~~
> expected ʽconst u8 * {aka const unsigned char *}ʼ but argument
> is of type ʽconst char *ʼ
> static inline bool is_valid_ether_addr(const u8 *addr)
> ^~~~~~~~~~~~~~~~~~~
> warning: pointer targets in passing argument 2 of
> ʽether_addr_copyʼ differ in signedness [-Wpointer-sign]
> ether_addr_copy(ndev->dev_addr, mac_addr);
> ^~~~~~~~
> expected ʽconst u8 * {aka const unsigned char *}ʼ but argument
> is of type ʽconst char *ʼ
> static inline void ether_addr_copy(u8 *dst, const u8 *src)
>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>

Applied.