Re: [PATCH v2 6/7] ocxl: Add an IOCTL so userspace knows what CPU features are available

From: Nicholas Piggin
Date: Mon May 07 2018 - 23:50:44 EST


On Tue, 08 May 2018 10:41:55 +1000
"Alastair D'Silva" <alastair@xxxxxxxxxxx> wrote:

> On Mon, 2018-05-07 at 20:14 +0200, Frederic Barrat wrote:
> >
> > Le 18/04/2018 Ã 03:08, Alastair D'Silva a Ãcrit :
> > > From: Alastair D'Silva <alastair@xxxxxxxxxxx>
> > >
> > > In order for a userspace AFU driver to call the Power9 specific
> > > OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually
> > > make that call.
> > >
> > > Signed-off-by: Alastair D'Silva <alastair@xxxxxxxxxxx>
> > > ---
> > > Documentation/accelerators/ocxl.rst | 1 -
> > > drivers/misc/ocxl/file.c | 25
> > > +++++++++++++++++++++++++
> > > include/uapi/misc/ocxl.h | 4 ++++
> > > 3 files changed, 29 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/accelerators/ocxl.rst
> > > b/Documentation/accelerators/ocxl.rst
> > > index ddcc58d01cfb..7904adcc07fd 100644
> > > --- a/Documentation/accelerators/ocxl.rst
> > > +++ b/Documentation/accelerators/ocxl.rst
> > > @@ -157,7 +157,6 @@ OCXL_IOCTL_GET_METADATA:
> > > Obtains configuration information from the card, such at the
> > > size of
> > > MMIO areas, the AFU version, and the PASID for the current
> > > context.
> > >
> > > -
> >
> >
> > Intended?
> >
> > Other than that,
> > Acked-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxxxxxxx>
> >
>
> Nope, I'll fix that, thanks.
>

Just to be clear, this is for OCXL features. I would just make that
explicit in the title (s/CPU/OCXL).

Thanks,
Nick