Re: [PATCH v2 2/2] pinctrl: generic: improve apply_setting error verbosity

[Matheus Castello]

Hi Linus,

thanks for the tips, I will study this to break dependency from OF.

Best Regards,
Matheus Castello

On 05/02/2018 08:51 AM, Linus Walleij wrote:
> On Tue, May 1, 2018 at 9:10 PM, Matheus Castello
> <matheus@xxxxxxxxxxxxxxx> wrote:
>
> > For generic pinconf: print the dev_error with the pinctrl vendor
> > driver name, error code, the sub-node property name used and the
> > pin that was tried to set.
> >
> > Improves the undestading of the error if use a generic sub-node
> > property that generic-pinconf can do parse but the vendor pinctrl
> > driver does not support.
> >
> > Signed-off-by: Matheus Castello <matheus@xxxxxxxxxxxxxxx>
>
> > +#include <linux/pinctrl/pinconf-generic.h>
> >   #include "core.h"
> >   #include "pinconf.h"
> >
> > @@ -169,9 +170,21 @@ int pinconf_apply_setting(const struct pinctrl_setting *setting)
> >                                  setting->data.configs.configs,
> >                                  setting->data.configs.num_configs);
> >                  if (ret < 0) {
> > +#ifdef CONFIG_OF
>
> This doesn't seem right.
>
> If this is restricted for OF only the root cause to why it is
> like that needs to be found and the code refactored to fit anyone,
> there is also ACPI support in the works I think, surely they should
> be able to get verbose messages.
>
> >                          dev_err(pctldev->dev,
> > -                               "pin_config_set op failed for pin %d\n",
> > +                               "%s error %d setting %s for pin %d\n",
> > +                               pctldev->desc->name, ret,
> > +                               pinconf_generic_get_param_property_name(
> > +                                       pctldev, setting->data.configs.num_configs,
> > +                                       setting->data.configs.configs),
> >                                  setting->data.configs.group_or_pin);
>
> This doesn't seem right. First argument is a %d, yet this
> is pctldev->desc->name?
>
> Something is fishy with the argument list.
>
> Yours,
> Linus Walleij