Re: [PATCH v10 02/25] x86/mm: define ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
From: Punit Agrawal
Date: Tue May 08 2018 - 07:04:41 EST
Laurent Dufour <ldufour@xxxxxxxxxxxxxxxxxx> writes:
> Set ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT which turns on the
> Speculative Page Fault handler when building for 64bit.
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Laurent Dufour <ldufour@xxxxxxxxxxxxxxxxxx>
> arch/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index d8983df5a2bc..ebdeb48e4a4a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -30,6 +30,7 @@ config X86_64
> select MODULES_USE_ELF_RELA
> select X86_DEV_DMA_OPS
> select ARCH_HAS_SYSCALL_WRAPPER
> + select ARCH_SUPPORTS_SPECULATIVE_PAGE_FAULT
I'd suggest merging this patch with the one making changes to the
architectural fault handler towards the end of the series.
The Kconfig change is closely tied to the architectural support for SPF
and makes sense to be in a single patch.
If there's a good reason to keep them as separate patches, please move
the architecture Kconfig changes after the patch adding fault handler
It's better to enable the feature once the core infrastructure is merged
rather than at the beginning of the series to avoid potential bad
fallout from incomplete functionality during bisection.
All the comments here definitely hold for the arm64 patches that you
plan to include with the next update.
> # Arch settings