Re: [PATCH] selftests/intel_pstate: Improve test, minor fixes

From: Shuah Khan
Date: Tue May 08 2018 - 16:27:57 EST


On 04/10/2018 04:11 PM, Daniel DÃaz wrote:
> A few changes improve the overall usability of the test:
> * fix a hard-coded maximum frequency (3300),
> * don't adjust the CPU frequency if only evaluating results,
> * fix a comparison for multiple frequencies.
>
> A symptom of that last issue looked like this:
> ./run.sh: line 107: [: too many arguments
> ./run.sh: line 110: 3099
> 3099
> 3100-3100: syntax error in expression (error token is \"3099
> 3100-3100\")
>
> Because a check will count how many differente frequencies
> there are among the CPUs of the system, and after they are
> tallied another read is performed, which might produce
> different results.
>
> Signed-off-by: Daniel DÃaz <daniel.diaz@xxxxxxxxxx>

Applied to linux-kselftest fixes for 4.17-rc5

thanks,
-- Shuah