RE: [PATCH v3 2/2] mtd: rawnand: fsl_ifc: use bit-wise majority to recover the contents of ONFI parameter

From: Wan, Jane (Nokia - US/Sunnyvale)
Date: Tue May 08 2018 - 17:29:59 EST


Hi Thomas,

I've sent v4 of the patches based on the comments.

Thank you.
Jane

> -----Original Message-----
> From: Thomas Petazzoni [mailto:thomas.petazzoni@xxxxxxxxxxx]
> Sent: Tuesday, May 08, 2018 6:13 AM
> To: Wan, Jane (Nokia - US/Sunnyvale) <jane.wan@xxxxxxxxx>
> Cc: Boris.Brezillon@xxxxxxxxxxx; miquel.raynal@xxxxxxxxxxx;
> dwmw2@xxxxxxxxxxxxx; computersforpeace@xxxxxxxxx; richard@xxxxxx;
> marek.vasut@xxxxxxxxx; yamada.masahiro@xxxxxxxxxxxxx;
> prabhakar.kushwaha@xxxxxxx; shawnguo@xxxxxxxxxx;
> jagdish.gediya@xxxxxxx; shreeya.patel23498@xxxxxxxxx; Bos, Ties (Nokia -
> US/Sunnyvale) <ties.bos@xxxxxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/2] mtd: rawnand: fsl_ifc: use bit-wise majority to
> recover the contents of ONFI parameter
>
> Hello,
>
> On Mon, 7 May 2018 09:34:15 -0700, Jane Wan wrote:
> > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid
> > CRC values, the bit-wise majority may be used to recover the contents
> > of the parameter pages from the parameter page copies present.
> >
> > Signed-off-by: Jane Wan <Jane.Wan@xxxxxxxxx>
>
> Minor nit: the commit title contains "fsl_ifc", but this commit doesn't change
> anything in the fsl_ifc driver, it fixes the NAND core.

[Jane] Removed the "fsl_ifc" from the subject in v4.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and
> Kernel engineering https://bootlin.com