Re: [PATCH REPOST] Revert mm/vmstat.c: fix vmstat_update() preemption BUG
From: Andrew Morton
Date: Tue May 08 2018 - 19:03:04 EST
On Mon, 7 May 2018 09:31:05 +0200 Vlastimil Babka <vbabka@xxxxxxx> wrote:
> In any case I agree that the revert should be done immediately even
> before fixing the underlying bug. The preempt_disable/enable doesn't
> prevent the bug, it only prevents the debugging code from actually
> reporting it! Note that it's debugging code (CONFIG_DEBUG_PREEMPT) that
> production kernels most likely don't have enabled, so we are not even
> helping them not crash (while allowing possible data corruption).
I don't see much benefit in emitting warnings into end-users' logs for
bugs which we already know about.
The only thing this buys us is that people will hassle us if we forget
to fix the bug, and how pathetic is that? I mean, we may as well put
printk("don't forget to fix the vmstat_update() bug!\n");