Re: [PATCH v3] ppc64le livepatch: implement reliable stacktrace for newer consistency models

From: Michael Ellerman
Date: Tue May 08 2018 - 21:41:16 EST


Josh Poimboeuf <jpoimboe@xxxxxxxxxx> writes:

> On Tue, May 08, 2018 at 10:38:32AM +0200, Torsten Duwe wrote:
>> On Mon, 7 May 2018 10:42:08 -0500
>> Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
>>
>> > The subject doesn't actively describe what the patch does, maybe
>> > change it to something like:
>> >
>> > powerpc: Add support for HAVE_RELIABLE_STACKTRACE
>> >
>> > or maybe
>> >
>> > powerpc: Add support for livepatch consistency model
>>
>> Maybe $SUBJECT? You're absolutely right, the old subject was just a
>> leftover of my original attempt to just set the flag, before Miroslav
>> corrected me. I just kept on copying it without a second thought. Thanks
>> for noting.
>
> Generally we refer to it as "the consistency model". So I would
> propose a minor edit:
>
> ppc64le/livepatch: Implement reliable stack tracing for the consistency model

We use "powerpc" as the prefix.

So I've used:

powerpc/livepatch: Implement reliable stack tracing for the consistency model


cheers