Re: [PATCH v7 23/24] ASoC: qcom: apq8096: Add db820c machine driver

[Srinivas Kandagatla]

Thanks for the review Banajit.

On 09/05/18 10:15, Banajit Goswami wrote:
> On 5/1/2018 5:08 AM, Srinivas Kandagatla wrote:
> > This patch adds support to DB820c machine driver.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   sound/soc/qcom/Kconfig   |   9 ++
> >   sound/soc/qcom/Makefile  |   2 +
> >   sound/soc/qcom/apq8096.c | 238 
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 249 insertions(+)
> > +    link = card->dai_link;
> > +
> > +    for_each_child_of_node(node, np) {
> > +        cpu = of_get_child_by_name(np, "cpu");
> > +        platform = of_get_child_by_name(np, "platform");
> > +        codec = of_get_child_by_name(np, "codec");
> > +
> > +        if (!cpu) {
> > +            dev_err(dev, "Can't find cpu DT node\n");
> clean up missing to kfree(card->dai_link)?
Yep, I will fix error path in next version.
> > +            return -EINVAL;
> > +        }
> > +
> > +                return ret;
> > +            }
> > +            link->no_pcm = 1;
> > +            link->ignore_suspend = 1;
> ignore_suspend will also need to be set for FE DAIs?
Okay!
> > +            link->ignore_pmdown_time = 1;
> > +            link->be_hw_params_fixup = apq8096_be_hw_params_fixup;
> > +        } else {
> > +            link->platform_of_node = link->cpu_of_node;
> > +            link->codec_dai_name = "snd-soc-dummy-dai";
> > +            link->codec_name = "snd-soc-dummy";
> > +            link->dynamic = 1;
> > +        }

> > +

> > +
> > +static void apq8096_unbind(struct device *dev)
> > +{
> > +    struct snd_soc_card *card = dev_get_drvdata(dev);
> > +
> > +    component_unbind_all(dev, card);
> > +    snd_soc_unregister_card(card);
> Should sound card not be unregistered first, before calling 
> component_unbind_all()?
Yep, I will give that a go.

thanks,
srini

>