Re: [RFC] sched: Distinguish between idle_cpu calls based on desired effect

From: Rohit Jain
Date: Wed May 09 2018 - 12:35:19 EST


Hi Peter,


On 05/09/2018 01:51 AM, Peter Zijlstra wrote:
On Mon, May 07, 2018 at 04:41:17PM -0700, Rohit Jain wrote:
In commit 247f2f6f3c706b40b5f3886646f3eb53671258bf we distinguish
between idle_cpu when the vcpu is not running for scheduling threads.
However, idle_cpu function is used at other places for actually checking
whether the state of the CPU is idle or not. Hence splitting the use of
that function based on the desired return value.
Yes, that looks OK.

Great! Let me change the comment and send out v2.


for your gitconfig:

[core]
abbrev = 12
[alias]
one = show -s --pretty='format:%h (\"%s\")'

$ git one 247f2f6f3c706b40b5f3886646f3eb53671258bf
247f2f6f3c70 ("sched/core: Don't schedule threads on pre-empted vCPUs")

which gives the normal commit quote style.


Thanks! updated :)

Regards,
Rohit