Re: [PATCH v3 2/2] mm: ignore memory.min of abandoned memory cgroups

From: Roman Gushchin
Date: Wed May 09 2018 - 14:12:06 EST


On Thu, May 03, 2018 at 01:38:35PM -0400, Johannes Weiner wrote:
> On Thu, May 03, 2018 at 12:43:58PM +0100, Roman Gushchin wrote:
> > If a cgroup has no associated tasks, invoking the OOM killer
> > won't help release any memory, so respecting the memory.min
> > can lead to an infinite OOM loop or system stall.
> >
> > Let's ignore memory.min of unpopulated cgroups.
> >
> > Signed-off-by: Roman Gushchin <guro@xxxxxx>
> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> > Cc: Michal Hocko <mhocko@xxxxxxxx>
> > Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
>
> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
>
> I wouldn't mind merging this into the previous patch. It's fairly
> small, and there is no reason to introduce an infinite OOM loop
> scenario into the tree, even if it's just for one commit.

OK, makes sense.
Here is an updated version: I've merged two commits into one,
added a small note about empty cgroups to docs and rebased to mm.

Andrew, can you, please, pull this one?
Thank you!

--